Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add links, minor changes in documentation #1716

Closed
wants to merge 1 commit into from

Conversation

Beelzenef
Copy link

GitHub Issue (If applicable): #443

PR Type

What kind of change does this PR introduce?

  • Documentation content changes

doc/articles/getting-started-tutorial-1.md Outdated Show resolved Hide resolved
doc/articles/getting-started-tutorial-1.md Outdated Show resolved Hide resolved
@@ -344,6 +344,10 @@ The Uno.UI TextBlock supports the Text property as well as the

For more information, see the [TextBlock](https://msdn.microsoft.com/en-us/library/windows/apps/windows.ui.xaml.controls.textblock.aspx) class.

---

To see this controls in action, visit [UnoPlatform Playground](https://playground.platform.uno/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This addition makes sense, but would be interesting at the top instead.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to the top!

doc/articles/getting-started-tutorial-1.md Outdated Show resolved Hide resolved
@jeromelaban
Copy link
Member

Thank yo for your contribution !

@@ -221,6 +221,8 @@ Note that the default language can be defined using the `DefaultLanguage` msbuil

## Supported Uno.UI Controls

To see this controls in action, visit [UnoPlatform Playground](https://playground.platform.uno/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To see this controls in action, visit [UnoPlatform Playground](https://playground.platform.uno/)
To see these controls in action, visit [UnoPlatform Playground](https://playground.platform.uno/)

@@ -344,6 +346,8 @@ The Uno.UI TextBlock supports the Text property as well as the

For more information, see the [TextBlock](https://msdn.microsoft.com/en-us/library/windows/apps/windows.ui.xaml.controls.textblock.aspx) class.

---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
---

@ghuntley
Copy link
Member

ghuntley commented Oct 8, 2019

Howdy @Beelzenef, there's a couple conflicts. Can you please enable https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork

For greater collaboration, you can allow commits on branches you've created from forks. Permission to commit to your forked branches is limited to those with push access to the upstream repository of the fork.

@Beelzenef
Copy link
Author

edit for maintainers checked! 👍

@ghuntley
Copy link
Member

@Beelzenef howdy 👋 I tried to push to your branch and was unable to. Can you please double check permissions?

image

@ghuntley ghuntley added triage/needs-information Indicates an issue needs more information in order to work on it. and removed triage/needs-information Indicates an issue needs more information in order to work on it. labels Oct 11, 2019
@jeromelaban
Copy link
Member

Thanks for your contribution, this PR has become stale and if you wish resume the work, please reopen this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage/needs-information Indicates an issue needs more information in order to work on it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants